Skip to content

Comments

Add databinding support for ftp client#1498

Merged
niveathika merged 7 commits intoballerina-platform:masterfrom
niveathika:master
Oct 31, 2025
Merged

Add databinding support for ftp client#1498
niveathika merged 7 commits intoballerina-platform:masterfrom
niveathika:master

Conversation

@niveathika
Copy link
Contributor

Purpose

$subject ballerina-platform/ballerina-library#6529

Examples

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility

@codecov
Copy link

codecov bot commented Oct 9, 2025

Codecov Report

❌ Patch coverage is 63.46154% with 76 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.25%. Comparing base (bf0199c) to head (9eed9ab).
⚠️ Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
...java/io/ballerina/stdlib/ftp/client/FtpClient.java 57.57% 33 Missing and 9 partials ⚠️
...ina/stdlib/ftp/ContentByteStreamIteratorUtils.java 52.17% 10 Missing and 1 partial ⚠️
ballerina/content_byte_stream.bal 41.17% 10 Missing ⚠️
...o/ballerina/stdlib/ftp/client/FtpClientHelper.java 70.83% 5 Missing and 2 partials ⚠️
ballerina/client_endpoint.bal 88.46% 3 Missing ⚠️
...connector/contractimpl/VfsClientConnectorImpl.java 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1498      +/-   ##
============================================
- Coverage     84.75%   81.25%   -3.51%     
- Complexity      248      369     +121     
============================================
  Files            28       39      +11     
  Lines          1305     1856     +551     
  Branches        162      276     +114     
============================================
+ Hits           1106     1508     +402     
- Misses          134      229      +95     
- Partials         65      119      +54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This comment was marked as outdated.

@niveathika niveathika requested a review from Copilot October 30, 2025 19:56
@niveathika niveathika marked this pull request as ready for review October 30, 2025 19:57
@niveathika niveathika added the Skip GraalVM Check This will skip the GraalVM compatibility check label Oct 30, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 20 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sonarqubecloud
Copy link

Copy link
Member

@SachinAkash01 SachinAkash01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@niveathika niveathika merged commit c0f8de8 into ballerina-platform:master Oct 31, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip GraalVM Check This will skip the GraalVM compatibility check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants